Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gap between footer logo and links #28542

Closed
amanr-dev opened this issue Mar 12, 2024 · 16 comments
Closed

Fix gap between footer logo and links #28542

amanr-dev opened this issue Mar 12, 2024 · 16 comments

Comments

@amanr-dev
Copy link

At the react.dev/learn & react.dev/community or any route add a gap between footer's logo and links

screenshot

Screenshot 2024-03-12 124202

@rhen99
Copy link

rhen99 commented Mar 12, 2024

Is that site on GitHub?

@sahiladit
Copy link

sahiladit commented Mar 12, 2024

issue : #28542
Can you assign this to me?
Can you help me , I know what is the problem and I can resolve but I don't know how to start?Should I clone the file first?

@Luguito
Copy link

Luguito commented Mar 13, 2024

Hey @amanr-dev, I was checking and i saw everything alright. I checked on a few resolutions and all seems to be fine. Could you provide more information to replicate that UI error ?

@kodaliakhil
Copy link

Hey @amanr-dev, I checked both react.dev/learn & react.dev/community on all resolutions and everything seems to be fine.

@amanr-dev amanr-dev closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@Harshit1723
Copy link

I'm proficient with this,Can you assign it to me

@pwbriggs
Copy link

@Harshit1723 the resolution was that this issue isn't reproducible on other devices. Can you reproduce this issue on your device? If so, please open a new issue with instructions for how to repro.

Thanks!

@RitaDee
Copy link

RitaDee commented Mar 20, 2024

Could you assign this issue to me? I can reproduce it on my device:

Screenshot 2024-03-20 at 09 49 17

I am using a Macbook.

Steps to reproduce:

  • Open the website link
  • Scroll to the footer and you will see there is no space between the loge and the (link)[https://opensource.fb.com/]

Suggestion:

The space between the logo and the link should look like this:

image

Instead of this:

image

@amanr-dev amanr-dev reopened this Mar 20, 2024
@amanr-dev
Copy link
Author

@RitaDee, assigned to you

@RitaDee
Copy link

RitaDee commented Mar 20, 2024

Thank you, @amanr-dev for assigning this issue to me.

@pwbriggs
Copy link

@RitaDee I think you misunderstood the issue. The Meta Open Source logo is supposed to look like that (as seen on https://opensource.fb.com). I think the issue @amanr-dev was referring to was this one:

s

Thanks anyway though! ❤️

@sahiladit
Copy link

It seems fine ,which system are you using?i'm not getting this issue?

@amanr-dev
Copy link
Author

one

Yes , you are right

@amanr-dev
Copy link
Author

It seems fine ,which system are you using?i'm not getting this issue?

My device's screen size is 1519 × 742

@sahiladit
Copy link

I think you should close this issue.

@sahiladit
Copy link

Screenshot 2024-03-20 at 9 16 35 PM I checked this on my system but it is correctly aligned.

@amanr-dev
Copy link
Author

Thank you, @amanr-dev for assigning this issue to me.

Hi @RitaDee, I think I should close this issue a second time. The reason is that the code for the website is not available in the Repository.

@amanr-dev amanr-dev closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants