"Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op." has no context

[dantman]

The "Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op." warning contains no context of what component setState was run on.

setState can happen at any time and changes to another component can be the cause of an unmount that results in the setState happening when unmounted so it's hard to even link the most recent code chagne you made to what setState call is responsible.

Simply including the displayName in the message like other warnings have should help devs at least a little in tracking down the source of this warning.

[zpao]

This sounds like a great idea.

[evankline]

+1

[machiaveli88]

+1

[tennisrodman]

+1

[jgod]

+1

[zpao]

Please stop +1ing, it adds zero value. We have already identified that this is a good idea.

[dantman]

GitHub really needs to automatically consolidate +1 comments into a single block and do a digest email for +1s.

[edvinerikson]

Got an PR for this: #3913

New message will be like this:

Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. Please check the code for the ExampleApplication component. This is a no-op.

[edvinerikson]

PR is merged so we should probably close this now.

[zpao]

Thanks for taking this on!

[seanchen1991]

Is the new context-sensitive warning working for everyone? I'm getting the old warning without any context on 0.13.3.

[zpao]

#3913 was not shipped to 0.13.x

[gilsho]

+1

[enadav]

+1

[zpao]

The fix was landed, any additional +1 is pure noise. Please stop.

[AndrewBestbier]

+1 ;)

[axelg12]

+1