Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only enqueue attachRefs if refs are present #4037

Merged
merged 1 commit into from Jun 5, 2015
Merged

Only enqueue attachRefs if refs are present #4037

merged 1 commit into from Jun 5, 2015

Conversation

sophiebits
Copy link
Collaborator

for #4036

@sebmarkbage
Copy link
Collaborator

I tried this exact fix in www so it should work but I wasn't sure. So thanks. :)

@sophiebits
Copy link
Collaborator Author

Yeah – you can see attachRefs already checks this same condition and there's no way that _currentElement should change between now and then.

sophiebits added a commit that referenced this pull request Jun 5, 2015
@sophiebits
Merge pull request #4037 from spicyj/ref-trans
ba81b60 
Only enqueue attachRefs if refs are present
@sophiebits sophiebits merged commit ba81b60 into facebook:master Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sophiebits @sebmarkbage @facebook-github-bot