Set the owner during traverseAllChildren #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
force-pushed
the
ownersforcontext
branch
from
3994222
to
fcfda10
Compare
| expect(console.error.calls.length).toBe(1); | ||
| expect(console.error.calls[0].args[0]).toContain( | ||
| 'Any use of a keyed object' | ||
| ); |
There was a problem hiding this comment.
Can you assert that "Foo" is also in the message?
There was a problem hiding this comment.
It is actually not in the message. We are pulling it off the stateful module in our internal logs.
|
👍 |
This is basically just adding some context to the warning in ReactFragment so that we can more easily find the callers.
sebmarkbage
force-pushed
the
ownersforcontext
branch
from
fcfda10
to
cd1ab32
Compare
sebmarkbage
added a commit
that referenced
this pull request
Aug 6, 2015
Set the owner during traverseAllChildren
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically just adding some context to the warning in ReactFragment
so that we can more easily find the callers.
We only need this temporarily. It will likely not go out in a release.
cc @spicyj