Added support for more HTML attributes: summary
#4607
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,6 +150,7 @@ var HTMLDOMPropertyConfig = { | |||
| sizes: MUST_USE_ATTRIBUTE, | |||
| span: HAS_POSITIVE_NUMERIC_VALUE, | |||
| spellCheck: null, | |||
| summary: MUST_USE_ATTRIBUTE, | |||
There was a problem hiding this comment.
I just did a quick test - looks like this can be set with a property or attribute, so let's make this null to retain option value (MUST_USE_* denotes that only 1 way of setting the value is possible so we can't use the other even if it's faster).
PS, thanks for jumping on this quickly :)
hekar
force-pushed
the
add/html-table-summary-attr
branch
from
9c3a22c
to
70fa446
Compare
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
hekar
force-pushed
the
add/html-table-summary-attr
branch
from
70fa446
to
be1fc79
Compare
|
Couldn't test yesterday, because was setting up a new development machine. Gave it a quick test and it looks good. Thanks for the help |
This attribute is used on <table> to support screen readers. It is deprecated, so take a look at <caption> instead.
|
Thanks! |
zpao
added a commit
that referenced
this pull request
Aug 14, 2015
Added support for more HTML attributes: `summary`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the
summaryattribute to the<table></table>element.See issue #4603