Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The name "JSX" is already taken, use "XJS" instead? #50

Closed
subtleGradient opened this issue Jun 3, 2013 · 2 comments
Closed

The name "JSX" is already taken, use "XJS" instead? #50

subtleGradient opened this issue Jun 3, 2013 · 2 comments

Comments

@subtleGradient
Copy link
Contributor

JSX Has been the file extension for ExtendScript files since at least 2005.
http://www.adobe.com/devnet/scripting.html

ExtendScript supports some amount of E4X syntax, but is not compatible with the facebook/jsx syntax.

Since at least May 15th 2012 "jsx" has been "a faster, safer, easier JavaScript".
http://jsx.github.io
https://github.com/jsx
@subtleGradient
Copy link
Contributor Author

The XJS project hasn't gotten any code since it was created in 2011 http://code.google.com/p/xjs/source/list

@vjeux
Copy link
Contributor

vjeux commented Jul 21, 2013

We're 2 months into the release, let's close it out :)

@vjeux vjeux closed this as completed Jul 21, 2013
@ustadkhan ustadkhan mentioned this issue Mar 26, 2019
Closed
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@taneliang
[Optimize flamechart][1/4] Add flamechart to ReactProfilerData
b9f310c 
This commit begins a stack of PRs that optimizes our flamechart.
Broadly, we need to replace the use of Speedscope's flamechart types
with our own types that are optimized for our rendering code.

As flamechart was always moved around together with ReactProfilerData,
it makes sense to move flamechart into it. That also necessitates moving
preprocessFlamechart into preprocessData.

This PR works towards #50.

* `yarn flow`: errors present, but no errors in affected code.
* `yarn lint`
* `yarn start`
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@taneliang
[Optimize flamechart][2/4] Replace Speedscope types with custom stack…
d049bf9 
… frame type

Lays groundwork for #75 by reducing the flamechart data passed around
the app.

Was also intended to help #50 by moving some division operations from
the hot render loops into preprocessFlamechart, but any performance
gains are negligible.

* `yarn flow`: no errors in modified code
* `yarn lint`
* `yarn start`: no performance difference
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@taneliang
[Optimize flamechart][4/4] Split FlamechartView into row views
5fe70a3 
Allow the view system to render only affected flamechart rows. This
greatly improves flamechart hover performance, which has a high impact
on our app's performance as the flamechart is the slowest view to
render.

Also adds a new `ColorView` view that fills the flamechart area with a
solid background color to fix these issues:

1. Black empty areas appearing below flamecharts without much stack
   depth
2. Lines appearing between flamechart rows. My hypothesis is that these
   are appearing due to subpixel rendering, even though the flamechart
   rows' `visibleArea`s are all integers.

Related to #50.

* `yarn flow`: no errors in changed code
* `yarn lint`
* `yarn start`: 60 FPS hovers on our Facebook.com profile
* `yarn test`
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@taneliang
[Optimize flamechart][1/4] Add flamechart to ReactProfilerData
415dc16 
This commit begins a stack of PRs that optimizes our flamechart.
Broadly, we need to replace the use of Speedscope's flamechart types
with our own types that are optimized for our rendering code.

As flamechart was always moved around together with ReactProfilerData,
it makes sense to move flamechart into it. That also necessitates moving
preprocessFlamechart into preprocessData.

This PR works towards #50.

* `yarn flow`: errors present, but no errors in affected code.
* `yarn lint`
* `yarn start`
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@taneliang
[Optimize flamechart][2/4] Replace Speedscope types with custom stack…
1f46ef2 
… frame type

Lays groundwork for #75 by reducing the flamechart data passed around
the app.

Was also intended to help #50 by moving some division operations from
the hot render loops into preprocessFlamechart, but any performance
gains are negligible.

* `yarn flow`: no errors in modified code
* `yarn lint`
* `yarn start`: no performance difference
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@taneliang
[Optimize flamechart][4/4] Split FlamechartView into row views
fe433c8 
Allow the view system to render only affected flamechart rows. This
greatly improves flamechart hover performance, which has a high impact
on our app's performance as the flamechart is the slowest view to
render.

Also adds a new `ColorView` view that fills the flamechart area with a
solid background color to fix these issues:

1. Black empty areas appearing below flamecharts without much stack
   depth
2. Lines appearing between flamechart rows. My hypothesis is that these
   are appearing due to subpixel rendering, even though the flamechart
   rows' `visibleArea`s are all integers.

Related to #50.

* `yarn flow`: no errors in changed code
* `yarn lint`
* `yarn start`: 60 FPS hovers on our Facebook.com profile
* `yarn test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@subtleGradient @vjeux