-
Notifications
You must be signed in to change notification settings - Fork 45.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide react-addons.js in distributions #5243
Comments
react addons are shipped as independent packages in 0.14. You should now install and require them as needed. |
Yes, that's another option. But I need the packages as webjars (http://www.webjars.org/). I tried to have them created for the addon packages, but the procedure fails because the github repository is not specified for the NPM packages:
|
haha ew. That requirement likely infers a development hell I don’t want to know about :) |
Unfortunately some of the addons use internals of React which aren't exposed in the browser build so this isn't really possible for us. We recommend consuming the addons from npm so you have control over exactly what gets bundled. #5388 sounds doable though. |
Oooh, webjars; that's pretty fancy :). |
There should be an additional
react-addons.js
file in the distribution package. In a multi-page app, there could be pages that need onlyreact.js
without the addons and some that need the addons as well. Currently that means that you add react-with-addons to all pages to avoid loading the react.js portion twice.The text was updated successfully, but these errors were encountered: