Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide react-addons.js in distributions #5243

Closed
jochenberger opened this issue Oct 22, 2015 · 5 comments
Closed

Provide react-addons.js in distributions #5243

jochenberger opened this issue Oct 22, 2015 · 5 comments

Comments

@jochenberger
Copy link

There should be an additional react-addons.js file in the distribution package. In a multi-page app, there could be pages that need only react.js without the addons and some that need the addons as well. Currently that means that you add react-with-addons to all pages to avoid loading the react.js portion twice.

@iamdustan
Copy link
Contributor

react addons are shipped as independent packages in 0.14. You should now install and require them as needed.

@jochenberger
Copy link
Author

Yes, that's another option. But I need the packages as webjars (http://www.webjars.org/). I tried to have them created for the addon packages, but the procedure fails because the github repository is not specified for the NPM packages:

Failed!
The source repository for react-addons-update 0.14.0 could not be determined but is required to published to Maven Central.  This will need to be fixed in the project's package metadata.

@iamdustan
Copy link
Contributor

haha ew. That requirement likely infers a development hell I don’t want to know about :)

@sophiebits
Copy link
Collaborator

Unfortunately some of the addons use internals of React which aren't exposed in the browser build so this isn't really possible for us. We recommend consuming the addons from npm so you have control over exactly what gets bundled. #5388 sounds doable though.

@jimfb
Copy link
Contributor

jimfb commented Nov 5, 2015

Oooh, webjars; that's pretty fancy :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants