-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umbrella: New Devtools API #5306
Comments
I remember somebody trying to call |
I hit a similar issue around not getting prop type validation warnings as mocha reran my tests on file system changes. While resetting state would be a fine solution I would strongly prefer to get programatic access to prop type validation failures. The real thing that, I believe, @glenjamin and I want to do is write tests that assert no prop type validations have failed. If we had the ability to clear |
In the end the extensible system we tried to design didn’t really work out. Even with very few warnings, it was quite slow in development, and also pretty complicated. We can design a better one now with the new engine, but I’d like to begin with scoping it down just to a warning hook first. We can track that in #4302. |
As per conversation with @sebmarkbage, it would be cool if React emitted events that allowed any attached devtools to listen for relevant events occurring in the core. The emitted events could be just descriptive enough that devtools could track whatever internal state it wants. For instance, a devtool could track perf by seeing how long various operations are taking (marked by start and end of the operation). Or a devtool could emit useful warnings (all our core warnings could be rolled into a devtools module/package, and by tracking state internally we could avoid routing the only-useful-for-warnings data throughout the core).
Anyway, the following are relevant:
shouldComponentUpdate
and get statistics on the results. Gather other per-component statistics like number of setState calls and renders.The text was updated successfully, but these errors were encountered: