Use a custom event type for our event dispatching in ReactErrorUtils #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just prepend |
It turns out that IE doesn't like when native events types are used. There may have been more involved at play but this fixes the issue.
zpao
force-pushed
the
non-native-event-name-dispatch
branch
from
6f9ac03
to
29523d0
Compare
|
@zpao updated the pull request. |
zpao
added a commit
that referenced
this pull request
Oct 30, 2015
Use a custom event type for our event dispatching in ReactErrorUtils
zpao
added a commit
to zpao/react
that referenced
this pull request
Nov 2, 2015
…atch Use a custom event type for our event dispatching in ReactErrorUtils (cherry picked from commit 12c214a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that IE doesn't like when native events types are used. There may
have been more involved at play but this fixes the issue.
Fixes #5324