Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #5458

Merged
merged 1 commit into from
Nov 13, 2015
Merged

Update deps #5458

merged 1 commit into from
Nov 13, 2015

Conversation

chicoxyzzy
Copy link
Contributor

  • update eslint, babel-eslint, eslint-plugin-react
  • update fbjs-scripts
  • update del

@jimfb
Copy link
Contributor

jimfb commented Nov 12, 2015

At the very least, we'll need to squash these three commits into a single commit before merging.

Staying up-to-date seems generally good. Just curious if there was anything that forced/motivated this change, or was it just cleanup?

@zpao and @spicyj because npm.

@chicoxyzzy
Copy link
Contributor Author

There are no any important reasons for updating this. I just noticed del 2.0.2 is used by other packages such as eslint for example so I thought its time to update del version used in gulpfile. So I've updated eslint packages as well as I did last week. fbjs-scripts includes .eslinrc so I updated it too.

I have split these changes into three commits to make it possible to cherry-pick or revert some of them if necessary but I surely can squash them into one.

@jimfb
Copy link
Contributor

jimfb commented Nov 12, 2015

Normally we squash, but there are sometimes exceptions. I'll let @spicyj or @zpao decide about squashing and/or merging this one.

@zpao
Copy link
Member

zpao commented Nov 12, 2015

FYI: No changes to eslintrc have been made in fbjs-scripts and the changes that have been made there don't affect us. The only actual change is to del, which now uses promises. Your change in the gulpfile should be right but I ran into issues in the past when using it with dependent tasks (but just testing again locally can't repro my original issues so meh).

We're not going to cherry-pick any of these to stable so let's squash.

zpao added a commit that referenced this pull request Nov 13, 2015
@zpao zpao merged commit 96549a1 into facebook:master Nov 13, 2015
@chicoxyzzy chicoxyzzy deleted the update_deps branch November 13, 2015 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants