Added LinkedInput addon. #5718
Merged
Added LinkedInput addon. #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zpao |
| var newprops = Object.assign({}, this.props); | ||
| newprops.value = LinkedValueUtils.getValue(this.props); | ||
| newprops.checked = LinkedValueUtils.getChecked(this.props); | ||
| newprops.valueLink=undefined; |
There was a problem hiding this comment.
delete newProps.valueLink (and yes, newProps)
|
@jimfb updated the pull request. |
|
Ping @zpao |
|
sure |
|
@zpao said:
Are we not using labels anymore? |
| @@ -0,0 +1,28 @@ | |||
| /** | |||
| * Copyright 2013-2015, Facebook, Inc. | |||
|
@jimfb updated the pull request. |
| ReactDOM = require('ReactDOM'); | ||
| }); | ||
|
|
||
| it('should basically work', function() { |
There was a problem hiding this comment.
:) this is my kind of test!
Lazy, stamping quickly. You know what I meant so let's not get too wrapped up in some official process. If the labels actually had any power, I'd use all the time. But as others mentioned, just fix the |
|
@jimfb updated the pull request. |
|
Has this ever worked? It seems to ignore the change handler on the link. |
|
Fixed this as part of #9385 even though nobody likely ever used this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LinkedInput addon. Goes here until @zpao decides how he wants to package/release it.