Friendly key warnings #6500
Merged
Friendly key warnings #6500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. | ||
| * | ||
| * @providesModule keyEscapeUtils |
There was a problem hiding this comment.
Let's capitalize the 'k' to become KeyEscapeUtils. The reason being that we capitalize classes (an object full of methods is basically a class) and reserve lowercase for function names.
|
Overall, this looks good to me. A couple of comments to fix. Also, if you can squash your commits ( |
hkal
force-pushed
the
friendly-key-warnings
branch
2 times, most recently
from
332b349
to
f9131dc
Compare
|
@hkal updated the pull request. |
- Abstract escaping - Provide human readible same key warnings
hkal
force-pushed
the
friendly-key-warnings
branch
from
f9131dc
to
d02ca23
Compare
|
Thanks @hkal |
zpao
pushed a commit
that referenced
this pull request
Apr 28, 2016
- Abstract escaping - Provide human readible same key warnings (cherry picked from commit dc6fc8c)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6475
Here's a first pass at this. I'm not entirely sold on the naming. Perhaps something like
wrap()andunwrap()might be a more appropriate name for these helper functions?cc @jimfb