Mention Enzyme on the test utils page. #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,8 @@ next: clone-with-props.html | |||
| var ReactTestUtils = require('react-addons-test-utils'); | |||
| ``` | |||
|
|
|||
| >Note: Airbnb has a released a new testing utility called [Enzyme](http://airbnb.io/enzyme/), which makes it easy to assert, manipulate, and traverse your React Components' output. If you're deciding on a unit testing library, it's worth checking out: [http://airbnb.io/enzyme/](http://airbnb.io/enzyme/) | |||
There was a problem hiding this comment.
A couple things.
- I don't think this needs to be a "Note:" but if you're going to do it like that please format it correctly (this will render the entire text bold)
- Probably don't need to link to it twice
- Are there other testing libraries worth linking to?
- "... released a new ..." will get dated. Want to phrase it in a way that's a bit more timeless since we probably won't change this text for 3 years ;)
There was a problem hiding this comment.
- I was wondering why the note was bold :P. Fixed the boldness.
- Eeh, ok, fixed.
- Not really. I think it's pretty clear that Enzyme stands out as a frontrunner (in the context of React). Did another framework jump out as particularly noteworthy to you?
- Fixed.
jimfb
force-pushed
the
testutils-enzyme
branch
2 times, most recently
from
ef6d2f7
to
9b000eb
Compare
|
👍 |
|
Also been hearing very positive things about it! |
zpao
pushed a commit
that referenced
this pull request
Apr 22, 2016
(cherry picked from commit a12aab1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been seeing some good things about Enzyme lately (eg. #5204 (comment)). People seem to like it.
Obviously we're not ready to deprecate our own test utils in favor of Enzyme, but I think we're doing our users a disservice if we don't communicate it as an alternative (or at least something to be aware of). This adds a note encouraging people to check it out.
cc @spicyj @gaearon