Fix return type in onlyChild's JSDoc #6573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type is a 'ReactElement' instead of a 'ReactComponent'.
|
We need to put an end to these one-line jsdoc fixes. Not sure what to do about the problem though. I don't want to reject these PRs because having wrong jsdocs is worse than having no jsdocs - it can be confusing as hell when the docs are lying to you. Anyway, thanks @elas7! If you're fixing up jsdocs, it would be great if you could go through and get as many of them as possible squeezed into a single PR. But if you're just browsing the code and happened to see this one, great, thanks for fixing! |
zpao
pushed a commit
that referenced
this pull request
Apr 28, 2016
The return type is a 'ReactElement' instead of a 'ReactComponent'. (cherry picked from commit 416f315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type is a
ReactElementinstead of aReactComponent.