Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information on element keys in JSX Gotchas #6751

Merged
merged 1 commit into from
May 13, 2016

Conversation

chadfawcett
Copy link
Contributor

I got the following warning when I implemented the mixed array form without keys on the JSX elements.

Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of...

Note: I have just completed the CLA

@jimfb
Copy link
Contributor

jimfb commented May 11, 2016

Seems reasonable ( 👍 )

@chadfawcett
Copy link
Contributor Author

One thing I was curious about was the translations. How does that work for getting the other versions updated?

@jimfb
Copy link
Contributor

jimfb commented May 11, 2016

@chadfawcett We don't have a good system for translation management. Right now, translators just watch for changes to the documentation and update the translations when they see changes. We will come up with a better system eventually. No action item on your end.

@jimfb jimfb merged commit 5d64199 into facebook:master May 13, 2016
zpao pushed a commit that referenced this pull request May 16, 2016
@chadfawcett chadfawcett deleted the jsx-gotchas-key branch August 30, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants