Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when element is missing in devtool #6869

Merged
merged 1 commit into from May 26, 2016

Conversation

sophiebits
Copy link
Collaborator

@sophiebits sophiebits commented May 25, 2016

Follow-up to #6867.

@sophiebits sophiebits added this to the 15.y.0 milestone May 25, 2016
@sophiebits
Copy link
Collaborator Author

@gaearon

@gaearon
Copy link
Collaborator

gaearon commented May 25, 2016

Thanks, can you add a test for it please?

@facebook-github-bot
Copy link

@spicyj updated the pull request.

@sophiebits sophiebits merged commit 21d271f into facebook:master May 26, 2016
@zpao zpao modified the milestones: 15.y.0, 15-next Jun 1, 2016
zpao pushed a commit to zpao/react that referenced this pull request Jun 8, 2016
zpao pushed a commit that referenced this pull request Jun 14, 2016
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
@kujon
Copy link

kujon commented Jul 4, 2016

Would you mind shedding some light on when exactly this warning is raised? Started getting it when doing:

componentWillMount() {
  if (process.env.BROWSER) {
    this.context.clientOnlyProperty();
  }
}

and struggling to understand how to address it.

@gaearon
Copy link
Collaborator

gaearon commented Jul 4, 2016

It's against internal bugs in React, it's not meant for users. If you see it please file a bug with an example that reproduces it.

@adamryvola
Copy link

Hello,
I had a react project (without any warring) and today i've installed this project on friend's pc and i get too many warrings. I think it is caused by react-bootstrap. In IDE console warn is: Warning: ReactComponentTreeDevtool: Missing React element for debugID 1 when building stack
Here is screen of console in browser
https://drive.google.com/open?id=0BzAI-U4-wrvCbTlCV3JuazZBUHc

PS: really sorry for my english

@keyz
Copy link
Contributor

keyz commented Jul 4, 2016

Hey @adamryvola,

Have you got a chance to take a look at https://fb.me/react-unknown-prop?

@gaearon
Copy link
Collaborator

gaearon commented Jul 4, 2016

@adamryvola The warning on your screenshot does not match the warning in your comment. If you can reproduce Warning: ReactComponentTreeDevtool: Missing React element for debugID please create an issue linking to a project that can reproduce it.

@adamryvola
Copy link

@keyanzhang I am reading it just right now, thanks!

@gaearon Thanks for fast answer. You are right, these two warring are not the same. I thought they are, because there were no warrings before. When I replace react-bootstrap <Button> with standard <button>, browser console is clear and ReactComponentTreeDevtool warn is still there (in server console). I will try reproduce this warn in another small project and then create issue.

Thank you for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants