Move null-input-value-prop warning into devtool, add stack trace #7040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
No tests? |
|
Tests still pass, they use toContain. Could change them to replace the stack trace with a dummy value and then assert the dummy value is there, but it didn't seem worth the effort. The important thing is that we are testing that the warning is firing (which we already test). |
| var ReactComponentTreeDevtool = require('ReactComponentTreeDevtool'); | ||
|
|
||
| var didWarnValueNull = false; | ||
| var warning = require('warning'); |
There was a problem hiding this comment.
Can you reorder so requires come first with a blank line after?
|
Okay. |
jimfb
force-pushed
the
input-null-warning
branch
from
6f9f6b7
to
0c14413
Compare
jimfb
force-pushed
the
input-null-warning
branch
from
0c14413
to
deb4728
Compare
|
@jimfb updated the pull request. |
Closed
|
Moving this back to semver-patch. I think it's probably up for some interpretation if this is minor or patch but it'll make the release process easier if it's patch (conflicts in other patch PRs). The warning is just more informative so I'm inclined to say it's ok. |
zpao
pushed a commit
that referenced
this pull request
Jul 8, 2016
(cherry picked from commit 97d89fa)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move null-input-value-prop warning into devtool, add stack trace