Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically bind scope of all user provided methods. #70

Closed
jordwalke opened this issue Jun 6, 2013 · 3 comments
Closed

Automatically bind scope of all user provided methods. #70

jordwalke opened this issue Jun 6, 2013 · 3 comments

Comments

@jordwalke
Copy link
Contributor

This is the common case - let's make it the default, so you don't need to wrap methods in React.autoBind.
@ericclemmons
Copy link
Contributor

+1 This would be extremely useful. There are several instances where you explicitly call a helper function, but have to litter your template with .bind(this) references for everything to work correctly.

I can't think of when a function would be expected to run outside of the component's scope...

@sophiebits
Copy link
Collaborator

(This was already committed in c9ecbac and should be in 0.4 when it comes out.)

@petehunt
Copy link
Contributor

petehunt commented Jul 1, 2013

Should have closed this :) thanks!

@petehunt petehunt closed this as completed Jul 1, 2013
bvaughn added a commit to bvaughn/react that referenced this issue Aug 13, 2019
@bvaughn
Merge pull request facebook#70 from gaearon/free-debug
16951fe 
Explicitly guard debug calls
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@taneliang
[Resize content][2/n] Implement ResizableSplitView (#107)
fcc9af4 
Summary
---

Implements `ResizableSplitView` and uses it to allow resizing of the
React measures view.

This PR also fixes the last PR's known issue where the flamechart does
not scroll vertically.

Implements #19. Implements #70.

Test Plan
---

* `yarn lint`
* `yarn flow`: no errors in changed code
* `yarn test`: no added tests, but everything still passes
* `yarn start`: manual testing:
    * Hover over resize bar to observe color change
    * Drag resize bar to resize
    * Resize bar position is clamped and cannot go offscreen or expand
      beyond the size of the lanes area
    * Resize bar remains visible on page resize
    * Content is independently vertically scrollable

There are still 3 independent horizontal pan/zoom areas, a known issue
carried over from the last PR in this stack. This will be fixed in the
next PR.
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@taneliang
[Resize content][2/n] Implement ResizableSplitView (#107)
6c4ad87 
Summary
---

Implements `ResizableSplitView` and uses it to allow resizing of the
React measures view.

This PR also fixes the last PR's known issue where the flamechart does
not scroll vertically.

Implements #19. Implements #70.

Test Plan
---

* `yarn lint`
* `yarn flow`: no errors in changed code
* `yarn test`: no added tests, but everything still passes
* `yarn start`: manual testing:
    * Hover over resize bar to observe color change
    * Drag resize bar to resize
    * Resize bar position is clamped and cannot go offscreen or expand
      beyond the size of the lanes area
    * Resize bar remains visible on page resize
    * Content is independently vertically scrollable

There are still 3 independent horizontal pan/zoom areas, a known issue
carried over from the last PR in this stack. This will be fixed in the
next PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sophiebits @ericclemmons @petehunt @jordwalke