Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type ReactCurrentOwner #7648

Merged
merged 1 commit into from Sep 2, 2016
Merged

Type ReactCurrentOwner #7648

merged 1 commit into from Sep 2, 2016

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Sep 2, 2016

Simpler than ReactOwner :)

@vjeux
Type ReactCurrentOwner
3eaa454 
Simpler than ReactOwner :)
@vjeux
Copy link
Contributor Author

vjeux commented Sep 2, 2016

Actually, it found out that my definition of ReactInstance was not complete on a different file assigning stuff to owner :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.233% when pulling 3eaa454 on vjeux:type_ReactCurrentOwner into a70acb3 on facebook:master.

@zpao
Copy link
Member

zpao commented Sep 2, 2016

👍

@vjeux vjeux added this to the 15-next milestone Sep 2, 2016
@vjeux vjeux merged commit 2559030 into facebook:master Sep 2, 2016
zpao
zpao reviewed Sep 2, 2016
View reviewed changes
src/renderers/shared/stack/reconciler/ReactInstanceType.js
@@ -34,4 +34,5 @@ export type ReactInstance = {
_mountImage: any,
// __DEV__
_debugID: DebugID,
_warnedAboutRefsInRender: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DUUUUDE

Copy link
Contributor Author

@vjeux vjeux Sep 3, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acdlite pushed a commit to acdlite/react that referenced this pull request Sep 9, 2016
@vjeux @acdlite
Type ReactCurrentOwner (facebook#7648)
581e4cd 
Simpler than ReactOwner :)
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
@vjeux @zpao
Type ReactCurrentOwner (#7648)
db985af 
Simpler than ReactOwner :)
(cherry picked from commit 2559030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gaearon gaearon

Labels
CLA Signed
Projects
None yet
Milestone
15.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vjeux @coveralls @zpao @gaearon