Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 07-forms.ko-KR.md #7809

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Update 07-forms.ko-KR.md #7809

merged 1 commit into from
Sep 26, 2016

Conversation

imjanghyuk
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (grunt test).
  5. Make sure your code lints (grunt lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

fix spelling

@ghost
Copy link

ghost commented Sep 26, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Sep 26, 2016
@ghost
Copy link

ghost commented Sep 26, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented Sep 26, 2016

Excuse my ignorance… Obviously something has changed but to my untrained eye, the git diff seems to show the same set of characters before and after. I'd love to learn what's happening if you can explain :)

@aweary
Copy link
Contributor

aweary commented Sep 26, 2016

@zpao second character in the first change and first character in the second change is different, if you look closely you'll see there's no horizontal line in between the two vertical lines in the new version.

'재' vs '제'

Not sure what either means, or what's right, but yeah 😄

@ghost ghost added the CLA Signed label Sep 26, 2016
@zpao
Copy link
Member

zpao commented Sep 26, 2016

Ah, I definitely missed that. Good catch :)

@zpao zpao merged commit 6032491 into facebook:master Sep 26, 2016
vjeux pushed a commit that referenced this pull request Sep 26, 2016
fix spelling
(cherry picked from commit 6032491)
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants