Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce confusion in testing documentation. #7818

Merged
merged 2 commits into from
Sep 28, 2016
Merged

Reduce confusion in testing documentation. #7818

merged 2 commits into from
Sep 28, 2016

Conversation

cpojer
Copy link
Contributor

@cpojer cpojer commented Sep 28, 2016

Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :)

See https://twitter.com/damusnet/status/780752042675597312

cc @lelandrichardson

Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :)

See https://twitter.com/damusnet/status/780752042675597312

cc @lelandrichardson

```
var ReactTestUtils = require('react-addons-test-utils');
```

> Note:
>
> Airbnb has released a testing utility called Enzyme, which makes it easy to assert, manipulate, and traverse your React Components' output. If you're deciding on a unit testing library, it's worth checking out: [http://airbnb.io/enzyme/](http://airbnb.io/enzyme/)
> Airbnb has released a testing utility called Enzyme, which makes it easy to assert, manipulate, and traverse your React Components' output. If you're deciding on a unit testing utility to use together with Jest, it's worth checking out: [http://airbnb.io/enzyme/](http://airbnb.io/enzyme/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that people might interpret this to mean that Enzyme is a utility specifically for Jest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I care about is the distinction that enzyme != Jest. Do you have a suggestion on how to improve the sentence? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, maybe add something to make it clear that it enzyme can be used with other testing libraries. Something like:

If you're deciding on a unit testing utility to use together with Jest, or another testing library, it's worth checking out

@cpojer
Copy link
Contributor Author

cpojer commented Sep 28, 2016

Updated to mention other "test runners". Sounds good?

@aweary
Copy link
Contributor

aweary commented Sep 28, 2016

@cpojer sounds good to me! 🎉

@vjeux vjeux added this to the 15-next milestone Sep 28, 2016
@vjeux vjeux merged commit 0990c93 into master Sep 28, 2016
vjeux pushed a commit that referenced this pull request Sep 28, 2016
* Reduce confusion in testing documentation.

Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :)

See https://twitter.com/damusnet/status/780752042675597312

cc @lelandrichardson

* Update 10.4-test-utils.md

(cherry picked from commit 0990c93)
@vjeux
Copy link
Contributor

vjeux commented Sep 28, 2016

It's going live as soon as travis pushes it :)

@vjeux
Copy link
Contributor

vjeux commented Sep 28, 2016

@vjeux vjeux deleted the cpojer-patch-1-1 branch September 28, 2016 02:28
@gaearon
Copy link
Collaborator

gaearon commented Sep 28, 2016

So that’s where the confusion comes from! Thanks for spotting.

@lelandrichardson
Copy link
Contributor

👍

@zpao zpao removed this from the 15-next milestone Oct 3, 2016
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
* Reduce confusion in testing documentation.

Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :)

See https://twitter.com/damusnet/status/780752042675597312

cc @lelandrichardson

* Update 10.4-test-utils.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants