-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce confusion in testing documentation. #7818
Conversation
Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :) See https://twitter.com/damusnet/status/780752042675597312 cc @lelandrichardson
|
||
``` | ||
var ReactTestUtils = require('react-addons-test-utils'); | ||
``` | ||
|
||
> Note: | ||
> | ||
> Airbnb has released a testing utility called Enzyme, which makes it easy to assert, manipulate, and traverse your React Components' output. If you're deciding on a unit testing library, it's worth checking out: [http://airbnb.io/enzyme/](http://airbnb.io/enzyme/) | ||
> Airbnb has released a testing utility called Enzyme, which makes it easy to assert, manipulate, and traverse your React Components' output. If you're deciding on a unit testing utility to use together with Jest, it's worth checking out: [http://airbnb.io/enzyme/](http://airbnb.io/enzyme/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear that people might interpret this to mean that Enzyme is a utility specifically for Jest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I care about is the distinction that enzyme != Jest. Do you have a suggestion on how to improve the sentence? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, maybe add something to make it clear that it enzyme can be used with other testing libraries. Something like:
If you're deciding on a unit testing utility to use together with Jest, or another testing library, it's worth checking out
Updated to mention other "test runners". Sounds good? |
@cpojer sounds good to me! 🎉 |
* Reduce confusion in testing documentation. Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :) See https://twitter.com/damusnet/status/780752042675597312 cc @lelandrichardson * Update 10.4-test-utils.md (cherry picked from commit 0990c93)
It's going live as soon as travis pushes it :) |
One day maybe... https://travis-ci.org/facebook/react/builds/163285316 |
So that’s where the confusion comes from! Thanks for spotting. |
👍 |
* Reduce confusion in testing documentation. Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :) See https://twitter.com/damusnet/status/780752042675597312 cc @lelandrichardson * Update 10.4-test-utils.md
Just wanted to add some clarity to this page and link to the react tutorial on Jest's website to give people more information. Also changed enzyme's definition from library to utility to help reduce the confusion. Hope this makes sense to everybody :)
See https://twitter.com/damusnet/status/780752042675597312
cc @lelandrichardson