Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve line numbers in "grunt test" #78

Closed
jordwalke opened this issue Jun 10, 2013 · 3 comments
Closed

Preserve line numbers in "grunt test" #78

jordwalke opened this issue Jun 10, 2013 · 3 comments
Assignees
@benjamn

Comments

@jordwalke
Copy link
Contributor

Line numbers are reported according to the package output, not the original file line number.
@ghost ghost assigned benjamn Jun 10, 2013
@benjamn
Copy link
Contributor

benjamn commented Jun 28, 2013

Had an idea for this: we could generate a browserified bundle where each module dynamically creates a <script> tag with the module source. Then hopefully PhantomJS could give the right line numbers for individual module files.

@benjamn
Copy link
Contributor

benjamn commented Jul 11, 2013

I'm actually going to do this.

@benjamn
Copy link
Contributor

benjamn commented Jul 22, 2013

This was fixed by c6c4657, although I should mention that I am still having trouble getting file names to show up in the test output.

@benjamn benjamn closed this as completed Jul 22, 2013
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@kartikcho
Fix tooltip bug, truncate componentName to use ellipsis (#78)
515e2cf 
* Fix tooltip bug, truncate componentName to use ellipsis

* Fix canvas reset bug

* remove ellipsis CSS, truncated componentName and script URL

* remove unused css, fix URL overflow, set ellipsis to 128, remove ellipsis for URL
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@taneliang
Fix tooltip (#121)
a9c1fad 
* Minor clean up of EventTooltip.js

* Fix root cause of #47 and improve tooltip styling

Tooltips would go offscreen because of the way `top` is defined. This
commit fixes that root cause by changing CanvasPage to position fixed so
that tooltips will be positioned relative to the DOM rather than the
CanvasPage div.

Undoes some of the changes made in #78 as this commit fixes the root
cause of the bug.

* Disable component name truncation

Although this was Brian's recommendation (see #67), I don't think
component names will be very long because the source code for those will
be really annoying.

* Set mouse location on every interaction to fix #87

* Introduce 768-char component name length limit

Covers the unlikely edge case that a component name is unreasonably
long.
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@kartikcho
Fix tooltip bug, truncate componentName to use ellipsis (#78)
474a424 
* Fix tooltip bug, truncate componentName to use ellipsis

* Fix canvas reset bug

* remove ellipsis CSS, truncated componentName and script URL

* remove unused css, fix URL overflow, set ellipsis to 128, remove ellipsis for URL
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@taneliang
Fix tooltip (#121)
d1b1b50 
* Minor clean up of EventTooltip.js

* Fix root cause of #47 and improve tooltip styling

Tooltips would go offscreen because of the way `top` is defined. This
commit fixes that root cause by changing CanvasPage to position fixed so
that tooltips will be positioned relative to the DOM rather than the
CanvasPage div.

Undoes some of the changes made in #78 as this commit fixes the root
cause of the bug.

* Disable component name truncation

Although this was Brian's recommendation (see #67), I don't think
component names will be very long because the source code for those will
be really annoying.

* Set mouse location on every interaction to fix #87

* Introduce 768-char component name length limit

Covers the unlikely edge case that a component name is unreasonably
long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamn @jordwalke