Move Safari onClick hack into ReactDOMComponent #8189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already where we trap non-bubbling events. We also already branch on the tag type so we know if it is interactive or not. This will let us get rid of the didPutListener and willDeleteListener abstractions. I use a simple onclick = emptyFunction to avoid the need for a bookkeeping map.
sophiebits
approved these changes
Nov 3, 2016
| @@ -911,6 +933,15 @@ ReactDOMComponent.Mixin = { | |||
| lastProps = ReactDOMTextarea.getHostProps(this, lastProps); | |||
| nextProps = ReactDOMTextarea.getHostProps(this, nextProps); | |||
| break; | |||
| default: | |||
| if (typeof lastProps.onClick !== 'function' && | |||
There was a problem hiding this comment.
Is it better to swap these so that the more restrictive condition comes first?
There was a problem hiding this comment.
Don't think it matters.
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
This is already where we trap non-bubbling events. We also already branch on the tag type so we know if it is interactive or not. This will let us get rid of the didPutListener and willDeleteListener abstractions. I use a simple onclick = emptyFunction to avoid the need for a bookkeeping map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already where we trap non-bubbling events. We also already branch on the tag type so we know if it is interactive or not.
This will let us get rid of the didPutListener and willDeleteListener abstractions.
I use a simple onclick = emptyFunction to avoid the need for a bookkeeping map.
Is it critical to unsubscribe from this when the listener is removed?