Stop relying on variable hoisting #8380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only declare the variable once in this scope, instead of declaring them multiple times in the same scope. This fixes facebook#8318, even though it might technically be a shortcoming in Rollup.
This was referenced Nov 22, 2016
|
I beleave it is already fixed. Also it looks you edited generated file. |
|
Haha oops indeed. |
|
Reverted. (As @btd noted it's already been fixed before.) |
|
Haha, whoops, sorry about that :) |
|
No worries, happens to everyone! |
|
Will this be released in version 15.4.1? |
|
Yea we'll include #8309 which changed it. |
|
Thank you 💌 |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
Only declare the variable once in this scope, instead of declaring them multiple times in the same scope. This fixes facebook#8318, even though it might technically be a shortcoming in Rollup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only declare the variable once in this scope, instead of declaring them multiple times in the same scope.
This fixes #8318, even though it might technically be a shortcoming in Rollup.