Restructure code to work around a Rollup bug #8384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's fix the 15-dev branch and then update the PR to point at that. That way stable branch at any point will always build a release version and not an intermediate release. Otherwise 👍 RRM should do the branch cleanup - I can double check and push it. |
gaearon
force-pushed
the
fix-tree-hook-rollup
branch
from
5ce325c
to
45cb029
Compare
zpao
approved these changes
Nov 22, 2016
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is directly again
15-stablebecause it's fixed in #8309 but tricky to cherry-pick.This fixes #8318.
It's not technically our bug, but it is a regression for Rollup users and it's easy for us to avoid.
In fact we already fixed this in master via #8309 because of the linter update.