[Fiber] Include owner in invalid element type invariant #8637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdustan
reviewed
Dec 27, 2016
| return getComponentName(fiber._debugOwner); | ||
| } | ||
| return null; | ||
| default: |
There was a problem hiding this comment.
will the other tag types ever have a component name to return?
There was a problem hiding this comment.
Maybe coroutines but we haven't implemented them fully yet. I'm aiming for parity for now.
|
This looks good to me. I think I should add the |
iamdustan
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds owner to invalid type invariant for Fiber. It's already there in Stack.
Ideally we'd add component stack later here too, but I want parity for now.
I changed
ReactDebugCurrentFiber.getCurrentFiberOwnerName()because it used to only work for host components since I first added it when working on DOM invariants/warnings. The problem is it didn't report the owner name when the owner is the current fiber itself. This is now fixed with an explicit switch on fiber tag.@iamdustan Since you're looking at Fiber and warnings would you like to review this?