Fix fiber/record-tests to work on windows (slash differences) #8796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jan 14, 2017
| const file = path.relative(root, fileResult.testFilePath); | ||
| const filePath = path.relative(root, fileResult.testFilePath); | ||
| // on windows, we still want to output forward slashes | ||
| const unixFilePath = filePath.replace(/\\/g, '/'); |
There was a problem hiding this comment.
Can you use path.normalize() for this?
There was a problem hiding this comment.
No, that still uses windows slashes
path.normalize('C:\\temp\\\\foo\\bar\\..\\');
// Returns: 'C:\\temp\\foo\\'
gaearon
approved these changes
Jan 14, 2017
| const file = path.relative(root, fileResult.testFilePath); | ||
| const filePath = path.relative(root, fileResult.testFilePath); | ||
| // on windows, we still want to output forward slashes | ||
| const unixFilePath = filePath.replace(/\\/g, '/'); |
|
Let's wait for Travis and if it passes, I'll merge. |
SimenB
reviewed
Jan 18, 2017
| @@ -106,12 +106,14 @@ function runJest(maxWorkers) { | |||
| function formatResults(runResults, predicate) { | |||
| const formatted = []; | |||
| runResults.testResults.forEach((fileResult) => { | |||
| const file = path.relative(root, fileResult.testFilePath); | |||
| const filePath = path.relative(root, fileResult.testFilePath); | |||
There was a problem hiding this comment.
Should be able to just do path.posix.relative here instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running record-tests on windows modifies the output due to slash incompatibility.
This change ensures the output is consistent across platforms which is required since the results are committed back to the repo.
Alternatively we could use slash to do this.