Add Flow reminder to PR template #8805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to add this step:
Could you add this too, and do it both in PR template and here? |
gaearon
requested changes
Jan 17, 2017
| 5. Make sure your code lints (`npm run lint`). | ||
| 6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`). | ||
| 7. If you haven't already, complete the CLA. | ||
| 3. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes. |
There was a problem hiding this comment.
Please enclose the command in backticks.
There was a problem hiding this comment.
Also, this step should probably come the last before CLA. It should be done after everything else is ready.
There was a problem hiding this comment.
That makes more sense, I've made the changes!
gaearon
approved these changes
Jan 17, 2017
gaearon
added
Documentation: needs merge to stable
and removed
GH Review: review-needed
labels
|
Thanks! |
aweary
pushed a commit
that referenced
this pull request
Jan 18, 2017
* Added flow to PR template * Added record-tests step to PR template and contribution docs * Updated order of PR checks (cherry picked from commit bfd5b18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CircleCI fails on Flow errors, I think it would be helpful to add a reminder to
npm run flowbefore submitting a PR.Formatting was inspired by the Draft.js PR template.