Add a link to "State Updates are Merged" in the forms doc #8851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jan 23, 2017
| @@ -231,6 +231,8 @@ class Reservation extends React.Component { | |||
| } | |||
| ``` | |||
|
|
|||
| Since `setState()` automatically merges a partial state into the current state ([State Updates are Merged](/react/docs/state-and-lifecycle.html#state-updates-are-merged)), we only needed to call it with the changed parts. | |||
There was a problem hiding this comment.
Let's just make "merges a partial [...]" itself a link.
gaearon
reviewed
Jan 23, 2017
| @@ -231,7 +231,7 @@ class Reservation extends React.Component { | |||
| } | |||
| ``` | |||
|
|
|||
| Since `setState()` automatically merges a partial state into the current state ([State Updates are Merged](/react/docs/state-and-lifecycle.html#state-updates-are-merged)), we only needed to call it with the changed parts. | |||
| Since `setState()` automatically [merges a partial state into the current state](/react/docs/state-and-lifecycle.html#state-updates-are-merged), we only needed to call it with the changed parts. | |||
There was a problem hiding this comment.
For consistency let's put this paragraph after the link. In fact maybe after the property explanation.
There was a problem hiding this comment.
👍. If we also rename nextState to partialState in the property explanation will it be more clear?
There was a problem hiding this comment.
Or pendingState, which is more accurate here.
gaearon
added
Documentation: needs merge to stable
and removed
GH Review: review-needed
labels
|
Added a few tweaks of my own (use |
gaearon
pushed a commit
that referenced
this pull request
Jan 23, 2017
* Added a link to "State Updates are Merged" * better inline links * moved the explanation down * Minor unrelated tweaks (cherry picked from commit eb89bc4)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was brought up on https://twitter.com/patrickkerrypei/status/823608012841648130