Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fbjs to 0.9.x #8898

Closed
dmnd opened this issue Jan 31, 2017 · 8 comments
Closed

Bump fbjs to 0.9.x #8898

dmnd opened this issue Jan 31, 2017 · 8 comments

Comments

@dmnd
Copy link
Contributor

dmnd commented Jan 31, 2017

Probably lots of React apps depend on babel-runtime, perhaps directly or maybe indirectly. This can problematic, though, because it can cause such apps to depend on two versions of core-js:

  1. Your babel using React app -> babel-runtime ^6.22.0 -> core-js ^2.4.0
  2. React -> fbjs ^0.8.4 -> core-js ^1.0.0

These two versions aren't semver compatible, so it means a project that depends on babel-runtime and also React will have two copies of core-js in use. A concrete example of this is a React app that also depends on Relay. There are probably many other such examples, though. It'd be nice to collapse this dependency into a single version of core-js.

React could bump its dependency to the latest fbjs which is fbjs 0.9.0-alpha.1. That's alpha right now, but it's been alpha for 7 months and probably you guys can arrange a stable release if you want to.

See also:

@gaearon
Copy link
Collaborator

gaearon commented Jan 31, 2017

Can you try to send a PR that updates it? I’m not sure what changed in fbjs.

@zpao
Copy link
Member

zpao commented Jan 31, 2017

Not worth doing yet. Follow along in the fbjs issue before anything is done. I'll update the changelog there as I've done in the past so it's easy to determine what has changed.

@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017

@zpao Still not a good time?

@zpao
Copy link
Member

zpao commented Oct 6, 2017

Was chatting with @sophiebits about this a couple weeks ago, were planning on getting to it after 16 launched… so I guess that's now 😀 Let's try to knock that out next week.

@gaearon
Copy link
Collaborator

gaearon commented Jan 2, 2018

@zpao Still wanna do it?

@adamnoakes
Copy link

any update on this?

@billyjanitsch
Copy link
Contributor

@adamnoakes the fbjs dependency was removed entirely in #13069.

@nhunzaker
Copy link
Contributor

Ah. It has! I believe this can be closed. Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants