Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocking not working with EventPluginRegistry #90

Closed
zpao opened this issue Jun 14, 2013 · 1 comment
Closed

Mocking not working with EventPluginRegistry #90

zpao opened this issue Jun 14, 2013 · 1 comment
Assignees
@benjamn

Comments

@zpao
Copy link
Member

zpao commented Jun 14, 2013

Since tests are injecting plugins with the same name multiple times, they fail. This shouldn't be happening since we dumpCache https://github.com/facebook/react/blob/master/src/eventPlugins/__tests__/AnalyticsEventPlugin-test.js#L33
@ghost ghost assigned benjamn Jun 14, 2013
@benjamn
Copy link
Contributor

benjamn commented Jun 14, 2013

Fixed by @yungsters via #91.

@benjamn benjamn closed this as completed Jun 14, 2013
@edmspjp edmspjp mentioned this issue Aug 22, 2014
Closed
@edmspjp edmspjp mentioned this issue Sep 28, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamn @zpao