Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't count skipped tests when calculating Fiber facts #9136

Merged
merged 1 commit into from Mar 8, 2017
Merged

Don't count skipped tests when calculating Fiber facts #9136

merged 1 commit into from Mar 8, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 8, 2017

This should fix it.

@gaearon
Copy link
Collaborator Author

gaearon commented Mar 8, 2017

Reference: https://github.com/facebook/jest/blob/7573421c2c9547f9ed8719227826529e4c81a91d/integration_tests/__tests__/jasmine_async-test.js#L123-L126.

It seemed a bit weird that skipped tests are called "pending" in Jasmine so I just summed passed with failing to be explicit.

@gaearon
Copy link
Collaborator Author

gaearon commented Mar 8, 2017

I think this should work.

@gaearon gaearon merged commit 266481d into master Mar 8, 2017
@gaearon gaearon deleted the gaearon-patch-3 branch March 8, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaearon @sebmarkbage @facebook-github-bot