Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jest-cli to the package.json for the Fiber record-tests script. #9270

Merged
merged 2 commits into from
Mar 28, 2017

Conversation

aickin
Copy link
Contributor

@aickin aickin commented Mar 28, 2017

The ./scripts/fiber/record-tests script currently doesn't work out of the box, because it depends on jest-cli, which isn't in package.json. Right now you have to manually npm install jest-cli to get the script to run correctly.

This PR just adds jest-cli to the package.json so that record-tests will work after a usual npm install.

Cheers!

@gaearon
Copy link
Collaborator

gaearon commented Mar 28, 2017

Mind updating Yarn lockfile too?

Also what's the difference between jest and jest-cli packages? Can/should we use just one or so we really need both?

@sophiebits
Copy link
Collaborator

They should be interchangeable I think. Let's just unify one one or the other? I guess jest is probably the most preferred name now.

@aickin
Copy link
Contributor Author

aickin commented Mar 28, 2017

@gaearon I always forget about yarn! Thanks for reminding me.

I took @spicyj's advice, though, and switched record-tests to use jest instead of jest-cli. I ran the script on my machine and it seemed to work fine; it ran the test suite and updated the timestamps on all three tests-(passing|failing|passing-except-dev).txt files. If there's more to do to test record-tests, let me know!

@sophiebits sophiebits merged commit aaabd65 into facebook:master Mar 28, 2017
@sophiebits
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants