Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the eager react-dom replacement on the rollup plugin #9346

Merged
merged 2 commits into from
Apr 5, 2017
Merged

Fixes the eager react-dom replacement on the rollup plugin #9346

merged 2 commits into from
Apr 5, 2017

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 5, 2017

The react-dom replacement in the Rollup plugin is far to eager, this makes it far less so.

gaearon
gaearon reviewed Apr 5, 2017
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not do this for all other cases?

@trueadm
Copy link
Contributor Author

trueadm commented Apr 5, 2017

@gaearon Valid point. I added those too.

@trueadm trueadm merged commit 3ebdd09 into facebook:master Apr 5, 2017
@gaearon
Copy link
Collaborator

gaearon commented Apr 5, 2017

Does it work?

@trueadm
Copy link
Contributor Author

trueadm commented Apr 5, 2017

Yep, it worked for me.

@gaearon gaearon deleted the fix_eager_react_dom_replace branch April 5, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trueadm @gaearon @facebook-github-bot