Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15.5 addon bugs #9384

Closed
10 tasks done
gaearon opened this issue Apr 8, 2017 · 10 comments
Closed
10 tasks done

15.5 addon bugs #9384

gaearon opened this issue Apr 8, 2017 · 10 comments

Comments

@gaearon
Copy link
Collaborator

gaearon commented Apr 8, 2017

This release has been a bit rocky. 😛
I'm keeping track of known issues to fix them up together in the next patch.

Regarding create-react-class:

  • Add docs link to the main docs. Currently just says "Documentation is WIP".
  • Add peer deps for React 15.5+ (15.5+ because of replaceState callback issue). Currently there are no peer deps at all, only dev deps.
  • Release update to NPM
@bvaughn
Copy link
Contributor

bvaughn commented Apr 8, 2017

Packages misses dependency on object-assign

Just the create-react-class package, right?

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 8, 2017

yep

@bvaughn
Copy link
Contributor

bvaughn commented Apr 9, 2017

FWIW the prop-types package.json does list "BSD-3-Clause" license which is, I think, the same as the one we have in the LICENSE files.

Going to tag @acdlite to do this too since it looks like he's made changes to prop-types that weren't pushed to 15.5-dev or 15-stable branches.

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 9, 2017

Going to tag @acdlite to do this too since it looks like he's made changes to prop-types that weren't pushed to 15.5-dev or 15-stable branches.

Did the source of truth move to reactjs/prop-types? Maybe we should delete folder in the branches.

@bvaughn
Copy link
Contributor

bvaughn commented Apr 9, 2017

Oh! You're right. Andrew mentioned that at one point but I forgot.

I'd add the license and patents file and do a point release of prop-types then.

@bvaughn
Copy link
Contributor

bvaughn commented Apr 9, 2017

I think there are a couple of additional things we need to do for create-react-class:

  • Add docs (at least a link to the main docs). Currently just says "Documentation is WIP".
  • Add peer deps for React 15.5+ (15.5+ because of replaceState callback issue). Currently there are no peer deps at all.
  • Release with peer deps and recently-added object-assign dep

@J-Dickson
Copy link

Formerly, React.createClass would set the displayName by default. This seems to have been omitted in create-react-class. Is this intentional? Thanks.

@bvaughn
Copy link
Contributor

bvaughn commented Apr 10, 2017

create-react-class still does this for DEV mode, no?

// Add verbose displayName to the function, which helps when looking
// at profiling tools.
if (typeof property === 'function' && spec.displayName) {
  proto[name].displayName = spec.displayName + '_' + name;
}

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 10, 2017

I think @J-Dickson is referring to Babel inferring displayName automatically (which is the case with React.createClass call). AFAIK we're waiting for a Babel release that does it for createReactClass. (@acdlite can clarify.)

But until it's not there, the codemod we're providing (see the blog post) adds a displayName manually to your existing classes.

@bvaughn
Copy link
Contributor

bvaughn commented Apr 10, 2017

Oh! So this: babel/babel/pull/5554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants