Fix ReactARTStack bundles to not include DOM Stack inside #9394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Apr 10, 2017
| function replaceInternalModules() { | ||
| // we inline these modules in the bundles rather than leave them as external | ||
| return { | ||
| "'react-dom'": `'${resolve('./src/renderers/dom/ReactDOM.js')}'`, |
There was a problem hiding this comment.
Rather than have this special case in all bundles, I opted for importing ReactDOM explicitly in test utils.
|
This doesn't matter much but makes ART bundle smaller for test cases (where we still use it). Which I guess is a minor benefit. But it also removes the |
trueadm
approved these changes
Apr 10, 2017
|
@gaearon This isn't working for me in master. If I run |
|
Ah I read the title of this PR incorrectly and assumed it was related. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only affects our internal FB bundles.