RFC: Remove build time extractErrors message when error codes can't be found #9555
Conversation
tomocchino
changed the title
| @@ -117,16 +117,6 @@ module.exports = function(babel) { | |||
| if (prodErrorId === undefined) { | |||
| // The error cannot be found in the map. | |||
| node[SEEN_SYMBOL] = true; | |||
| if (process.env.NODE_ENV !== 'test') { | |||
There was a problem hiding this comment.
Should we still keep this but put it behind some other NODE_ENV? E.g. for npm publish builds.
There was a problem hiding this comment.
I'd be happy to. Should we set a NODE_ENV = 'build' when we're building or something?
There was a problem hiding this comment.
@tomocchino Just change this to if (process.env.NODE_ENV === 'publish') {. There's no spec for this. Only convention. I just made up this one. We don't actually have to start using it yet because our publishing strategy/tooling is in flux.
|
@sebmarkbage I'm not sure how to add a new NODE_ENV. Want me to just abandon this? |
|
I just merged it as is because it’s too annoying. 😄 I don’t think this warning is very useful because we have the |
Per #9548 (comment) -- just removing these errors since they're noisy. The extract errors process is documented as part of releases, and we don't extract errors between releases.