[#9627] Fix componentWillUnmount test case in isMounted tests #9629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The package lives in the 15.6-dev branch for now: https://github.com/facebook/react/tree/15.6-dev/addons/create-react-class. We might split into its own repo at some point (but maybe not because we don't want to support it indefinitely). Do you mind opening the PR against that branch? |
|
Going to revisit this after 15.6 is out—until then we can't really merge because test will fail CI. |
mridgway
force-pushed
the
isMountedTestFix
branch
from
3af93a4
to
6a16251
Compare
mridgway
force-pushed
the
isMountedTestFix
branch
from
6a16251
to
90e3cb8
Compare
|
Updated create-react-class devDependency so that they could be merged in tandem without build failure. |
gaearon
approved these changes
Jun 20, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the test case mentioned in #9627 and adds checks for a component's mixins to ensure that they are also getting the correct values.