Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commented out code #9795

Merged
merged 1 commit into from Jun 5, 2017
Merged

Remove commented out code #9795

merged 1 commit into from Jun 5, 2017

Conversation

lipis
Copy link
Contributor

@lipis lipis commented May 27, 2017 •
edited

There is no clear benefit of keeping that info there.. if warnings will be added later to the rules it's very straightforward on what have to happen.

aweary
aweary approved these changes Jun 5, 2017
View reviewed changes
Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, might as well. Thanks!

@aweary aweary merged commit f4c9ad5 into facebook:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweary aweary aweary approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lipis @aweary @facebook-github-bot