-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate why CI got broken on master but PR passed #9864
Comments
This puzzled me. I didn't understand how the test failed for us now when on the CI run, it ran the test and showed it as passing: Then I remembered that we made a change to make tests properly run on CI a while back. So I think this is related to the CI change we made to the Jest task runner not turning an exit: |
Thanks for investigating! We might have some more PRs like this, so need to be mindful (and ideally rebase old PRs before merging). |
See this PR: #9550.
It passed CI on PR, but when merged to master, it had a test failure (which I later fixed in #9854).
I wonder if we're missing some check in PRs.
The text was updated successfully, but these errors were encountered: