Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dom-factories has a peerdep of ^15.5.4 #10358

Closed
brucewpaul opened this issue Aug 2, 2017 · 10 comments
Closed

react-dom-factories has a peerdep of ^15.5.4 #10358

brucewpaul opened this issue Aug 2, 2017 · 10 comments

Comments

@brucewpaul
Copy link

Do you want to request a feature or report a bug?

bug

What is the current behavior?

react-dom-factories has a peerdep of react@^15.5.4, but it seems as though it should work with any react@15

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).

n/a

What is the expected behavior?

react-dom-factories works with react@^15

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

react@15.4.2
@gaearon
Copy link
Collaborator

gaearon commented Aug 2, 2017

I think we should just remove the peer dependency. It’s not very helpful and we’ll have to keep bumping it on every release while we’d rather leave this package alone.

@ljharb
Copy link
Contributor

ljharb commented Aug 2, 2017

Maybe instead of removing it, set it to *?

@gaearon
Copy link
Collaborator

gaearon commented Aug 2, 2017

That works!

@gaearon
Copy link
Collaborator

gaearon commented Aug 2, 2017

Hmm. It doesn’t match prereleases. Which is pretty annoying for cases where we want people to try a beta.

gaearon added a commit that referenced this issue Aug 2, 2017
@gaearon
Remove React from peers of react-dom-factories
116a878 
Fixes #10358
@ljharb
Copy link
Contributor

ljharb commented Aug 2, 2017

*-rc? There's got to be some way to say "match anything, but error if there's no react"

@gaearon
Copy link
Collaborator

gaearon commented Aug 2, 2017

Fixed in 1.0.1 (I just removed them).

There's got to be some way to say "match anything, but error if there's no react"

AFAIK there isn’t 😞 . You could do with a direct dep when you control which prerelease you opt into, but we can’t do this from a peer. https://github.com/npm/node-semver#prerelease-tags

@gaearon gaearon closed this as completed Aug 2, 2017
@ljharb
Copy link
Contributor

ljharb commented Aug 2, 2017

Oh well - thanks for the fix :-) will it be released soon?

@gaearon
Copy link
Collaborator

gaearon commented Aug 2, 2017

Already released.

@ljharb
Copy link
Contributor

ljharb commented Aug 2, 2017

Amazing, thanks!

@brucewpaul
Copy link
Author

thanks for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @gaearon @brucewpaul