Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint tests #3971

Closed
zpao opened this issue May 28, 2015 · 2 comments · Fixed by #3985
Closed

Lint tests #3971

zpao opened this issue May 28, 2015 · 2 comments · Fixed by #3985
Assignees
@bgw

Comments

@zpao
Copy link
Member

zpao commented May 28, 2015

After #3968, the next thing we should do is start linting our tests. Historically we've ignored them due to lack of parser compatibility. But that shouldn't be a problem anymore. We may want to integrate https://www.npmjs.com/package/eslint-plugin-react to more aggressively lint our JSX in tests.

cc @PiPeep
@hzoo
Copy link
Contributor

hzoo commented May 28, 2015

A similar PR is being done in react-native too facebook/react-native#259 (adds babel-eslint, but also eslint-plugin-react)

@zpao
Copy link
Member Author

zpao commented May 28, 2015

Indeed. We have the benefit that we don't have to worry about anything internal yet so we can be more flexible :)

@zpao zpao assigned bgw May 28, 2015
bgw added a commit to bgw/react that referenced this issue May 29, 2015
@bgw
Enable linting for __tests__
9330414 
Closes facebook#3971.

> After facebook#3968, the next thing we should do is start linting our tests.
> Historically we've ignored them due to lack of parser compatibility.
> But that shouldn't be a problem anymore. We may want to integrate
> https://www.npmjs.com/package/eslint-plugin-react to more aggressively
> lint our JSX in tests.

I understand this diff touches a lot of stuff, so I tried to keep it to
a near-minimal set of changes to make eslint happy. If you're wondering
why I changed something, let me know and I'll try to map it up to the
rule that I was fixing it for.
@bgw bgw mentioned this issue May 29, 2015
Merged
bgw added a commit to bgw/react that referenced this issue Jun 1, 2015
@bgw
Enable linting for __tests__
21ca3f7 
Closes facebook#3971.

> After facebook#3968, the next thing we should do is start linting our tests.
> Historically we've ignored them due to lack of parser compatibility.
> But that shouldn't be a problem anymore. We may want to integrate
> https://www.npmjs.com/package/eslint-plugin-react to more aggressively
> lint our JSX in tests.

I understand this diff touches a lot of stuff, so I tried to keep it to
a near-minimal set of changes to make eslint happy.
@bgw bgw closed this as completed in #3985 Jun 1, 2015
This was referenced Jan 21, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Jul 18, 2020
Open
This was referenced Mar 7, 2021
Open
Open
Open
Open
This was referenced Nov 27, 2023
Open
Open
Open
Open
This was referenced May 14, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgw bgw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable linting for __tests__ bgw/react
3 participants
@zpao @bgw @hzoo