Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterable numbers breaks React #4776

Closed
zloirock opened this issue Sep 3, 2015 · 2 comments
Closed

Iterable numbers breaks React #4776

zloirock opened this issue Sep 3, 2015 · 2 comments

Comments

@zloirock
Copy link

zloirock commented Sep 3, 2015

Issue with the reproducible example here.

Full core-js build contains non-standard Number iterator. Theoretical, it can be added to ES in the future, it can be added (or already added) to another libraries. React should take into account possibility iterable numbers.
@benmosher benmosher mentioned this issue Sep 4, 2015
Closed
@sebmarkbage
Copy link
Collaborator

Well, the good news is that if this is already on enough pages, then introducing iterable numbers may not be web compatible anyway.

I think that this is only in DEV only code. Unfortunately a lot of pages incorrectly uses the DEV build of React.

@sophiebits
Copy link
Collaborator

"good news"

sophiebits added a commit to sophiebits/react that referenced this issue Sep 9, 2015
@sophiebits
Don't try to iterate over non-objects
b004bc5 
Fixes facebook#4776.
@sophiebits sophiebits mentioned this issue Sep 9, 2015
Merged
sophiebits added a commit that referenced this issue Sep 9, 2015
@sophiebits
Merge pull request #4823 from spicyj/gh-4776
3dbdb63 
Don't try to iterate over non-objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sophiebits @sebmarkbage @zloirock