Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Person is <<anonymous>> in IE, breaking tests #516

Closed
subtleGradient opened this issue Nov 11, 2013 · 2 comments · Fixed by #598
Closed

Person is <<anonymous>> in IE, breaking tests #516

subtleGradient opened this issue Nov 11, 2013 · 2 comments · Fixed by #598
Labels
Difficulty: starter

Comments

@subtleGradient
Copy link
Contributor 

Instance Types should throw for invalid instances.

Expected function to throw Invariant Violation: Invalid prop `testProp` supplied to `testComponent`, expected instance of `Person`. , but it threw Invariant Violation: Invalid prop `testProp` supplied to `testComponent`, expected instance of `<<anonymous>>`.

Expected function to throw Invariant Violation: Invalid prop `testProp` supplied to `testComponent`, expected instance of `Person`. , but it threw Invariant Violation: Invalid prop `testProp` supplied to `testComponent`, expected instance of `<<anonymous>>`.

Expected function to throw Invariant Violation: Invalid prop `testProp` supplied to `testComponent`, expected instance of `Person`. , but it threw Invariant Violation: Invalid prop `testProp` supplied to `testComponent`, expected instance of `<<anonymous>>`.
@zpao
Copy link
Member

zpao commented Nov 11, 2013

This is because we use fn.name (which is nonstandard) to get as good as possible invariants. In this case, I would be satisfied with a conditional in the test to set the right comparison string.

https://github.com/facebook/react/blob/master/src/core/ReactPropTypes.js#L128

sophiebits added a commit to sophiebits/react that referenced this issue Nov 24, 2013
@sophiebits
Be resilient to fn.name not existing in IE
685dec0 
Fixes facebook#516.
@sophiebits sophiebits mentioned this issue Nov 24, 2013
Merged
@subtleGradient
Copy link
Contributor Author

👍

@zpao zpao closed this as completed in #598 Nov 27, 2013
zpao added a commit that referenced this issue Nov 27, 2013
@zpao
Merge pull request #598 from spicyj/gh-516
5fbd810 
Be resilient to fn.name not existing in IE
@snyk-bot snyk-bot mentioned this issue Apr 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: starter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be resilient to fn.name not existing in IE sophiebits/react
2 participants
@subtleGradient @zpao