Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run tests built from files that exist in src/ #856

Closed
benjamn opened this issue Jan 9, 2014 · 2 comments · Fixed by #980
Closed

Only run tests built from files that exist in src/ #856

benjamn opened this issue Jan 9, 2014 · 2 comments · Fixed by #980
Assignees
@benjamn
Labels
Component: Build Infrastructure Type: Bug Type: Enhancement

Comments

@benjamn
Copy link
Contributor

benjamn commented Jan 9, 2014

Right now we run any tests we find in build/modules/, which includes tests still sitting around from previous builds that don't currently exist in src/.

cc @subtleGradient @spicyj
@ghost ghost assigned benjamn Jan 9, 2014
@zpao
Copy link
Member

zpao commented Jan 9, 2014

The occasional grunt clean isn't a bad thing.

@sophiebits
Copy link
Collaborator

True, just annoying when switching between branches.

@benjamn benjamn mentioned this issue Jan 27, 2014
Merged
benjamn added a commit to benjamn/react that referenced this issue Jan 28, 2014
@benjamn
Remove build/modules/ at beginning of grunt and grunt test.
864366d 
Little-known fact: instead of writing copies of compiled module files to
build/modules/, the bin/jsx-internal script actually just makes hard links
to the master versions of files in the .module-cache/, so re-populating
build/modules/ is very inexpensive.

Closes facebook#856.
@snyk-bot snyk-bot mentioned this issue Aug 4, 2021
Open
@snyk-bot snyk-bot mentioned this issue Aug 31, 2021
Open
This was referenced Nov 27, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamn benjamn

Labels
Component: Build Infrastructure Type: Bug Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove build/modules/ at beginning of grunt and grunt test benjamn/react
3 participants
@benjamn @sophiebits @zpao