transform ocaml pervasives interfaces to reason correctly #1474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master:
Actual result
Expected result
I think there is 2 issues here :
(=)
should mapped to(==)
'a -> 'a
should not become a tuppleThis PR fixes only the first one.
The second one seems to be a regression.Currently the Pervasives reason documentation page is misleading and I think this PR will fix it. E.g. https://reasonml.github.io/api/Pervasives.html#VAL(=)
And probably that one too #1427
I'm still a new to OCaml / Reason so feel free to tell me if I misunderstood something.