Support attributes/doc-comments on record type fields. #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:Fixes #1653 Test Plan:Test cases Reviewers: CC:
jordwalke
commented
Feb 12, 2018
| @@ -267,20 +266,17 @@ class boxA ('a) (init: 'a) = | |||
| * In non-curried sugar, the class_expr still sticks to "the simple thing". | |||
| */ | |||
| class boxB ('a) (init: 'a) = | |||
| [@stillOnTheReturnBecauseItsSimple] | |||
There was a problem hiding this comment.
I found the formatting change in this diff to be a slight improvement, especially if we were to allow omitting the brackets:
@attr {
bracedExpression
}
I imagine it could be pretty easily used to embed query languages for things like graphQL:
@query {
friends: {
},
otherField: {
}
}
|
Please let me know if any of the small formatting changes for attribute attachments didn't result in improvements and I'll be happy to revisit. |
This was referenced Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:Fixes #1653
Test Plan:Test cases
Reviewers:
CC: