Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse and print Ppat_open #2314

Merged
merged 9 commits into from Jan 27, 2019
Merged

Parse and print Ppat_open #2314

merged 9 commits into from Jan 27, 2019

Conversation

anmonteiro
Copy link
Member

fixes #2301

jordwalke
jordwalke reviewed Jan 8, 2019
View reviewed changes
formatTest/typeCheckedTests/expected_output/mlSyntax.4.04.0.re Outdated
type t = {name: string};
};

let foo = (Foo.{name}) => ();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add some more tests covering the various places patterns can occur? Destructuring tuples, switch statements etc.

jordwalke
jordwalke reviewed Jan 9, 2019
View reviewed changes
formatTest/test.sh

if [ "$MIN_VERSION" != "$BASE_NAME" ] && [ "$(version "$OCAML_VERSION")" -lt "$(version "$MIN_VERSION")" ]
then
notice " ☒ IGNORED REFMT STEP: Requires OCaml >= $MIN_VERSION"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch.

@anmonteiro
Copy link
Member Author

@jordwalke I added some more parsing rules to support parsing e.g. let Foo.[bar] = baz; and other patterns.

There's only one caveat with the current state of this PR: it parses let Foo.((bar, baz)) = qux; but not let Foo.(bar, baz) = qux;. I'm considering it future work to relax the double parens requirement.

@jordwalke
Copy link
Member

Cool, those seem like nice additions too. Is this ready to merge then?

@jordwalke
Copy link
Member

@kpsuperplane: The Azure builds are getting an error very similar to one you were getting on reason-native:

Definition name facebook.reason didn't correspond to a valid definition

Do you recall what the culprit is? How do I fix it?

@IwanKaramazow
Copy link
Contributor

IwanKaramazow commented Jan 12, 2019 •
edited

@jordwalke this should be ready to merge, @anmonteiro and I looked at it together yesterday.

The azure failure is weird, I'm seeing the same problem at #2319 (PR is ready), all tests seems to pass on the other ci's

@kpsuperplane
Copy link

@jordwalke I solved it last time by renaming the project to something else (e.g. "facebook-reason"), running a successful build, and renaming it back. Never really figured out the root cause though

@jordwalke jordwalke merged commit 11dddfc into reasonml:master Jan 27, 2019
@anmonteiro anmonteiro mentioned this pull request May 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordwalke jordwalke jordwalke left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Stack overflow with 3.3.7 and master 9914cc69
5 participants
@anmonteiro @jordwalke @IwanKaramazow @kpsuperplane @facebook-github-bot