Support OCaml 4.11 #2582
Merged
Support OCaml 4.11 #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
Note that there is a new syntax for string litteral in 4.11 |
|
For information, OCaml 4.11 is going to be released next week |
anmonteiro
force-pushed
the
anmonteiro/ocaml-4.11
branch
from
e40b0c5
to
1921cf5
Compare
anmonteiro
force-pushed
the
anmonteiro/ocaml-4.11
branch
from
48027c3
to
315af8e
Compare
|
@hhugo Where can I read about this string literal syntax? |
|
This is the PR for quoted extensions: ocaml/ocaml#8820. I didn't add support for it because it might warrant its own syntax discussion, so I'll leave that to people who care about those discussions. It doesn't add new AST nodes, so in the worst case we'll print them as strings today. I'm gonna go ahead and merge this, based on the justification above. |
I suspect it will just print them as quoted strings with extension points surrounding them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early PR that will hopefully allow us to support OCaml 4.11 when it's out (it's in alpha right now).
This is not expected to build, as it's currently dependent on let-def/merlin-extend#13 being merged.