Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Node v0.11, execute tests natively using --harmony-generators #1

Closed
benjamn opened this issue Oct 5, 2013 · 0 comments
Closed

In Node v0.11, execute tests natively using --harmony-generators #1

benjamn opened this issue Oct 5, 2013 · 0 comments
Labels
enhancement

Comments

@benjamn
Copy link
Collaborator

benjamn commented Oct 5, 2013

That is, in addition to transforming test/tests.es6.js into test/tests.es5.js, we should run the tests natively using the following command:

mocha --reporter spec --harmony-generators test/tests.es6.js

This will ensure that we maintain fidelity with the V8 implementation of generators, and (perhaps most importantly) allow Travis CI to verify fidelity in Node v0.11 with every push.
@benjamn benjamn closed this as completed in c8a8cc6 Oct 7, 2013
benjamn pushed a commit that referenced this issue Oct 24, 2013
@cpojer
Merge pull request #1 from facebook/runtime-style-tweaks
d414a29 
Counter pull request!
benjamn pushed a commit that referenced this issue Dec 3, 2013
@termi
Merge pull request #1 from facebook/issue65
55a2181 
Enable native support for let/const in node v0.11.2+
benjamn pushed a commit that referenced this issue Apr 8, 2014
@sophiebits
Merge pull request #1 from facebook/gh-103
3ef98a1 
Upgrade recast dependency to v0.5.16 to fix #103
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamn